Introduce mapping layer for variant analysis history items#2315
Merged
Introduce mapping layer for variant analysis history items#2315
Conversation
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
A couple of small questions, but looks pretty good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functions for DTO <-> domain model mappings. As part of this we've also modelled enums as DTOs which were previously not modelled.
Note that the mapping functions for the local queries are currently in
query-history-dto-mapperandquery-history-domain-mapperbut will be moved into local queries specific files in a separate PR.Checklist
N/A:
ready-for-doc-reviewlabel there.